test: regenerate vlasov1d config regression baselines for vmin key#314
Open
joglekara wants to merge 2 commits into
Open
test: regenerate vlasov1d config regression baselines for vmin key#314joglekara wants to merge 2 commits into
joglekara wants to merge 2 commits into
Conversation
The asymmetric velocity grid feature (#295) added vmin to each species grid dict dumped in array_config.pkl, but the pytest-regressions baselines were never regenerated. Regenerated with --force-regen; the diff is limited to the expected vmin: -vmax additions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_vlasov1d/test_config_regression.pyfails onmainfor all three configs: feat(vlasov1d): support asymmetric velocity grids (vmin != -vmax) #295 (asymmetric velocity grids) added avminkey to each species grid dict dumped inarray_config.pkl, but the pytest-regressions baselines were never regenerated.get_solver_quantities(adept/_vlasov1d/modules.py), sourced fromSpecies.from_config, which defaultsvmin = -vmax— so the recorded values (-6.4for electrons,-0.005for the multispecies ion grid) are just the historical symmetric grid, no behavior change.--force-regen; the diff is exactly 4 insertedvminlines across the three*_array_config.ymlfiles. Theconfig,units, andderived_configbaselines are untouched.Test plan
uv run --extra dev pytest tests/test_vlasov1d/test_config_regression.py— 12 passed🤖 Generated with Claude Code